CESNET / UltraGrid

UltraGrid low-latency audio and video network transmission system
http://www.ultragrid.cz
Other
495 stars 53 forks source link

[decklink] fix stereo 3D supportedFlags #204

Closed tmenari closed 2 years ago

tmenari commented 2 years ago

Fix a small bug in decklink video_display where supportedFlags is accidentally merged with outputFlags.

The bug results in supportedFlags getting set to bmdVideoOutputDualStream3D (16) | bmdSupportedVideoModeDualStream3D (2) == 18, but in the context of BMDSupportedVideoModeFlags the 16 means bmdSupportedVideoModeSDIQuadLink and thus causes failures on cards that do not support quad-link.

For example, this bug is benign on DeckLink 8K Pro, but will cause issues on DeckLink 4K Extreme 12G.

Also of note, and not solved here, is that the EXIT_IF_FAILED macro will not successfully terminate from within display_decklink_reconfigure_video.