CESNET / UltraGrid

UltraGrid low-latency audio and video network transmission system
http://www.ultragrid.cz
Other
485 stars 55 forks source link

Spout crashing on SPOUTLIBRARY::SetSpoutLogLevel() #352

Closed MartinPulec closed 8 months ago

MartinPulec commented 8 months ago

Originally posted by @zbynekdrlik in https://github.com/CESNET/UltraGrid/issues/348#issuecomment-1783558388

UltraGrid crashes when setting log level (both capture and display part) with following stacktrace (uv -t spout):

#0  0x00007ffffa771a77 in ucrtbase!_wtol () from C:\WINDOWS\System32\ucrtbase.dll
#1  0x00007ffffa772304 in ucrtbase!_wctomb_s_l () from C:\WINDOWS\System32\ucrtbase.dll
#2  0x00007ffffa772ed1 in ucrtbase!.stdio_common_vsprintf_s () from C:\WINDOWS\System32\ucrtbase.dll
#3  0x00007fffdc2e5c4f in SpoutLibrary!?_doLog@spoututils@@YAXW4SpoutLogLevel@1@PEBDPEAD@Z ()
   from C:\tools\msys64\home\toor\ultragrid-devel\bin\SpoutLibrary.dll
#4  0x00007fffdc2e26d2 in SpoutLibrary!??4spoutSenderNames@@QEAAAEAV0@AEBV0@@Z ()
   from C:\tools\msys64\home\toor\ultragrid-devel\bin\SpoutLibrary.dll
#5  0x00007ff6acc367cf in vidcap_spout_init (params=<optimized out>, state=0x41043ea0) at src/video_capture/spout.cpp:190
#6  0x00007ff6acba6c5d in initialize_video_capture (parent=0x14fb50, param=0x487d20, state=0x14fb38) at src/video_capture.cpp:158
#7  0x00007ff6accc573a in main (argc=3, argv=0x4d3cf0) at src/main.cpp:1403

reproducible in continuous (5ac3f93), 1.8.6, 1.8.5 but not in 1.8.4 and below.

zbynekdrlik commented 8 months ago

Ready for testing fixes :)

MartinPulec commented 8 months ago

Ready for testing fixes :)

Already built here. I've just waited for the build to be finished before reporting – it takes some half an hour.

MartinPulec commented 8 months ago

It looks like the issue is caused by the Spout pre-built library (version 2.007.010) no longer being compatible with the Spout headers in Git (version 2.007.012). When the library is built from sources in the Git, the problem no longer occurs. If this is correct, also other problems may occur.

Anyways, the libraries are not expected to be included in the repository in future as indicated in leadedge/Spout2#103.