search

CESNET / UltraGrid

UltraGrid low-latency audio and video network transmission system
http://www.ultragrid.cz
Other
485 stars 55 forks source link

Video quality is corrupted on newest continues build #358

Closed zbynekdrlik closed 7 months ago

zbynekdrlik commented 8 months ago

Hi, as I am forced to use continues nightly build as last stable version has not working spout I see that all videos played directly in one command from ndi/spout/dishow/screen to local gl/sdl video is corrupted

image

simple eg. command : uv -t dshow:11 -d gl

MartinPulec commented 8 months ago

Thanks again for reporting. If you think the vertical lines (not the top/bottom-most part that may or may not be similar problem), I don't think there is the bug. It seems to me that these are just missing data. If you look at the output, there should be percent loss, something like:

SSRC 0xe858b98b: 67872/67968 packets received (99.8588%), 96 lost, max loss 35

Ideally, there should be 100%. If you'll see a significant loss, it is partly because Windows network stack is not being capable to transmit over the localhost the uncompressed data stream – depending on your video properties it may be 1.5 Gbps (for FHD RGB) or proportionally more or less. You can look at extending buffers, but I am not sure if it will be possible to set on localhost in MSW. Or just use some compression, like -c libavcodec. Alternatively you can also avoid using the network stack for local preview with -x V:loopback (of course it won't be possible when really sending over a network).

as last stable version has not working

Just FYI, the "scheduled" term for next bug-fix release, that should fix it, is 20th. If needed, we can emit it earlier if you wish, but I don't think that the behavior will be different from "continuous" build in this respect.

zbynekdrlik commented 8 months ago

This is not appearing in last stable version 1.8.6. I will also test your ideas but it is different behavior between stable and nightly.

We are still in testing phase of usage ultragrid so no critical situation. Thankful that some github project have active maintenance :)

MartinPulec commented 7 months ago

Seems like I am able to reproduce with -t testcard:p -d gl.

zbynekdrlik commented 7 months ago

Today I am available to do tests. As you reproduce it, is my support needed anymore?

MartinPulec commented 7 months ago

As you reproduce it, is my support needed anymore?

As for now perhaps not, I'll write back with updates.

MartinPulec commented 7 months ago

Should be fixed by now and the builds are rebuilt as well.

zbynekdrlik commented 7 months ago

Solved - working excellently 💯