Centralize non-IPFIX to IPFIX conversion code

CESNET / ipfixcol

IPFIXcol is an implementation of an IPFIX (RFC 7011) collector

Other

64 stars 37 forks source link

Centralize non-IPFIX to IPFIX conversion code #137

Closed ghost closed 8 years ago

ghost commented 8 years ago

The code for converting non-IPFIX to IPFIX PDUs (base/src/input/{sctp,tcp,udp}/convert.{c,h} is currently duplicated among various input plugins. This is error-prone. Could we think about a way to centralize this code, perhaps under the 'util' umbrella?

ghost commented 8 years ago

Same question for some external libraries that are used at multiple code occasions, such as pugixml.

thorgrin commented 8 years ago

Done for the conversion code in the latest commit. The pugixml is more complicated, more packages depend on the same code. It would have to be in a shared library, which I do not want to do for the third party code.