CESNET / ipfixcol

IPFIXcol is an implementation of an IPFIX (RFC 7011) collector
Other
64 stars 37 forks source link

Broken test: 'one input + forwarding' #170

Closed ghost closed 8 years ago

ghost commented 8 years ago

The output of the test suite in your devel branch is currently as follows:

Testing 'basic - one input file'
Testing 'basic - two input files'
Testing 'basic - withdraw message'
Testing 'ipfixsend - enterprise fields,sctp'
Testing 'ipfixsend - two inputs sctp'
Testing 'ipfixsend - two inputs tcp'
Testing 'ipfixsend - two inputs udp'
Testing 'malformed - bad template field count'
Testing 'malformed - missing template 258'
Testing 'malformed - missingTmpl258,BadSetLength'
Testing 'malformed - missingTmpl258,BadSetLength(long)'
Testing 'malformed - no templates'
Testing 'malformed - valid header and zeros'
Testing 'one input + forwarding'
diff: out-second*: No such file or directory
Testing 'two inputs + filter by ipVersion'
Testing 'two inputs + joinflows'
Testing 'two inputs with same ODID'

Test 'basic - one input file': OK
Test 'basic - two input files': OK
Test 'basic - withdraw message': OK
Test 'ipfixsend - enterprise fields,sctp': OK
Test 'ipfixsend - two inputs sctp': OK
Test 'ipfixsend - two inputs tcp': OK
Test 'ipfixsend - two inputs udp': OK
Test 'malformed - bad template field count': OK
Test 'malformed - missing template 258': OK
Test 'malformed - missingTmpl258,BadSetLength': OK
Test 'malformed - missingTmpl258,BadSetLength(long)': OK
Test 'malformed - no templates': OK
Test 'malformed - valid header and zeros': OK
Test 'one input + forwarding': OK
Test 'two inputs + filter by ipVersion': OK
Test 'two inputs + joinflows': OK
Test 'two inputs with same ODID': OK

Testing done; 17/17 tests passed

As you can see, although no errors are reports, diff reports an error about a missing file. By the way, the fact that the test succeeds while an error occurs is already suspicious in itself...

thorgrin commented 8 years ago

Good point. The configuration of the forwarding plugin was not up to date and it caused the problem. I've fixed it and added a check so the test would fail in such a case in the future.