config.c: Improved logging and accuracy in case of XML comments

CESNET / ipfixcol

IPFIXcol is an implementation of an IPFIX (RFC 7011) collector

Other

64 stars 37 forks source link

config.c: Improved logging and accuracy in case of XML comments #23

Closed ghost closed 9 years ago

ghost commented 9 years ago

This pull request is a follow-up for #17. Besides some textual changes, it merely improves the handling of XML comments in case no intermediate plugins are specified for loading in startup.xml.

mikeek commented 9 years ago

There are 2 problems with your fix:

1) while loop will end with the first occurence of comment in configuration. Any intermediate plugins specification after this comment will not be processed.

2) Comments should be identified by checking node type (XML_COMMENT_NODE).

ghost commented 9 years ago

Right. Will add a fix to this pull request imminently; or did you already fix it?

mikeek commented 9 years ago

No, I didn't (only checked your pull request here on github).