search

CESNET / ipfixcol

IPFIXcol is an implementation of an IPFIX (RFC 7011) collector
Other
64 stars 37 forks source link

Stability fixes #35

Closed ghost closed 9 years ago

ghost commented 9 years ago

In addition to these fixes, I'd like to ask you to take a look at the following code fragments:

Both code fragments access conf->new_in and I wonder whether there's no need for locking intermediate.in_q_mutex and output_manager_config.in_q_mutex, respectively.

mikeek commented 9 years ago

But output manager and each intermediate plugin has it's own conf structure. And each acces to conf->new_in is protected by mutex and conditional variable (lines 109 - 119 in intermediate_process.c and 156 - 166 in output_manager.c). Checking conf->new_in is only done after reading NULL message and NULL message is send after setting new input queue.