Fixed incorrect variable names

CESNET / ipfixcol

IPFIXcol is an implementation of an IPFIX (RFC 7011) collector

Other

64 stars 37 forks source link

Fixed incorrect variable names #93

Closed ghost closed 9 years ago

ghost commented 9 years ago

Several variables in storage.h were referring to 'records' while they should actually refer to 'sets':

MSG_MAX_TEMPLATES > MSG_MAX_TEMPL_SETS
MSG_MAX_OTEMPLATES > MSG_MAX_OPT_TEMPL_SETS
data_records_count > data_sets_count
templ_records_count > templ_sets_count
opt_templ_records_count > opt_templ_sets_count

mikeek commented 9 years ago

I agree with renaming MSG_MAX_* macros, but the rest is not correct. If you loook at lines 468-477 in preprocessor.c, the while loop is iterating over template records in one template set. So it really counts template records, not template sets. The same situation is for option templates at lines 484-492 and for data records at line 517 where data_set_process_records calls fill_metadata for each data record in set.

ghost commented 9 years ago

Fixed.