Closed jmuecke closed 7 months ago
Hello, please apply changes from branch feature-quic-tud (commit c5297ff). After this the merge request will be ready for merge.
Modify this if statement:
process/quic.cpp: In member function ‘void ipxp::QUICPlugin::set_client_hello_fields(ipxp::QUICParser*, ipxp::Flow&, ipxp::RecordExtQUIC*, const ipxp::Packet&, bool)’:
process/quic.cpp:265:33: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
265 | || (!new_quic_flow) && (quic_data->retry_scid_length == dcid_len))
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I applied the commit and modified that condition to get rid of the compiler warning.
I also changed part or the retry code, to only act upon the first retry packet.
We extend ipfixprobe's quic module by extracting the following additional QUIC meta information:
Additional improvements:
Limitations: