CESNET / ipfixprobe

BSD 3-Clause "New" or "Revised" License
37 stars 18 forks source link

FIX discrepanicies in IPT phists features #210

Closed hynekkar closed 2 months ago

hynekkar commented 2 months ago

In rare instances, when IPT equals -1, the packet was omitted from the IPT histograms, resulting in discrepancies between the packets transmitted and those recorded in the histogram. This pull request addresses the issue by ensuring that all IPT values less than 0 are treated as 0, as these cases are nearly equivalent to 0 IPT.

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@3a7a546). Learn more about missing BASE report.

Files Patch % Lines
process/phists.cpp 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #210 +/- ## ========================================= Coverage ? 40.60% ========================================= Files ? 100 Lines ? 9508 Branches ? 1405 ========================================= Hits ? 3861 Misses ? 4825 Partials ? 822 ``` | [Flag](https://app.codecov.io/gh/CESNET/ipfixprobe/pull/210/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CESNET) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/CESNET/ipfixprobe/pull/210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CESNET) | `40.60% <60.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CESNET#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.