CESNET / liberouter-gui

8 stars 4 forks source link

Unnecessary config.json inclusion #46

Open nerudaj opened 6 years ago

nerudaj commented 6 years ago

https://github.com/CESNET/liberouter-gui/blob/fddb535d5637ac73112b26adf84867643f89a748/bootstrap.py#L190

When bootstrapping modules, all files conforming to regex /config.json inside modules folder are considered to be configuration files valid to bootstrap script. This can lead to a lot of confusing warnings since files like tsconfig.json will be parsed as well (even though they should not).

Is there a reason why original approach with scanning only for modulename/config.json was deprecated and replaced with wildcard regex?