search

CESNET / libnetconf

C NETCONF library
Other
113 stars 83 forks source link

Corrected get-schema: was returning extra <data> nodes. #234

Closed mrmouro closed 7 years ago

mrmouro commented 7 years ago

Hi, during the weekend regression test we found out that the latest pull request related to user-defined rpcs and custom rpc-replies is broken for get-schema requests:

netconf> get-schema

  Set identifier of the schema to retrieve: ne

  Result:
<data xmlns="urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring">
    <data>
      <data/>
      <data/>
    </data>
    <data>
      <data>
        <data>
          <data>
            <data>
              <data>
                <data>
                  <data>
                    <data>
                      <data>module "ne" {
  namespace "urn:some:toaster";
  prefix "toaster";
...
...

the check for real node also needs to take into account the netconf state monitoring namespace.

thanks and best regards joao

michalvasko commented 7 years ago

Hi, you are correct, thanks.

Regards, Michal