Missing NC_PSPOLL_REPLY_ERROR in nc_ps_poll result

CESNET / libnetconf2

C NETCONF library

BSD 3-Clause "New" or "Revised" License

203 stars 147 forks source link

Missing NC_PSPOLL_REPLY_ERROR in nc_ps_poll result #443

Closed awesomenode closed 1 year ago

awesomenode commented 1 year ago

Hi,

When rpc-error is sent directly by libnetconf2 library, NC_PSPOLL_REPLY_ERROR flag is not set in nc_ps_poll result. For example, when sending this invalid netconf rpc:

<rpc xmlns:nc="urn:ietf:params:xml:ns:netconf:base:1.0">
  <invalid>
    <data/>
  </invalid>
</rpc>

Since this flag is used for out-rpc-errors, this will not be incremented correctly in this case.

libyang version: 2.1.132 sysrepo version: 2.2.125 libnetconf2 version: 2.1.39

Thank you in advance!

michalvasko commented 1 year ago

Right, fixed in the latest devel (failed to reference it properly).

awesomenode commented 1 year ago

Now it works with latest version, thanks!