DuplicationOptions: Missing support for Bitwise-OR operator |

[rbu9fe]

In contrast to other enumeration types DuplicationOptions doesn't support bitwise-OR | even though it says it's supported: Wraps LY_DUP_* flags. Supports operator|. It's simply missing in the list where operators are defined.

Also please note the typo in the description, it should read LYD_DUP_* rather than LY_DUP_*.

[jktjkt]

Thanks, this patch series should fix that (please feel free to add feedback via Gerrit if you feel like doing that):

• add missing LYDDUP* flags
• docs: fix a typo in LYDDUP* enum
• Add missing operator| for LYDDUP*

[jktjkt]

Fixed, merged, thanks for reporting this.

[rbu9fe]

Thanks for the quick fix!

[rbu9fe]

Sorry but now when building I receive this error: .../src/utils/enum.hpp:90:15: error: ‘LYD_DUP_WITH_PRIV’ was not declared in this scope; did you mean ‘LYD_DUP_WITH_PARENTS’?

And perhaps you may want to remove the trailing comma behind WithPriv = 0x20, as it's the last enum entry (to be consistent with the others).

[jktjkt]

You need the latest devel of libyang, I guess we forgot to bump the requirement in CMake. That trailing comma is there by design to minimize future diffing.

[rbu9fe]

CMake is referring to libyang>=2.1.124. I'm using 2.1.124. Do I need to bump to 2.1.128?

[jktjkt]

yes

[jktjkt]

actually, my recent build was against libyang 2.1.134, and the latest one upstream is 2.1.139

[rbu9fe]

That still fails with the same error. I don't know if I'm missing something but the master branch doesn't know LYD_DUP_WITH_PRIV: See https://github.com/CESNET/libyang/blob/master/src/tree_data.h#L1906C19-L1906C19

[syyyr]

libyang-cpp always tracks the devel branch of libyang (even for the master branch of libyang-cpp)

[jktjkt]

(fixed via CMake's minimal required version of libyang once again)