CESR-lab / ucla-roms

GNU General Public License v3.0
5 stars 11 forks source link

bug: order of calls to `checkdims` #36

Open dafyddstephenson opened 2 months ago

dafyddstephenson commented 2 months ago

In main.F , the call to get_grid occurs before the call to set_scoord. This subsequently triggers a call to checkdims in which the values of Cs_r in the grid file are compared with the model values, which are 0, as they have not been calculated yet. This causes the model to fail.

The fix appears to be simple - move set_scoord to above get_grid in main.

I have issued PR #37 that takes this approach and all tests pass.

D