search

CExA-project / ddc

DDC is a discrete domain computation library.
https://ddc.mdls.fr
Other
29 stars 3 forks source link

Splines limitation: buffer of same size as input data #187

Open blegouix opened 9 months ago

blegouix commented 9 months ago

In Splines branch, spline_builder_batched.hpp file, the object spline_tr is a buffer with the same size as spline (corresponding to the input/output). It implies that half memory has to be filled with buffer (at least).

Improving it is theorically feasible but may require to change the classes APIs (because we currently have solve_inplace method which acts on the buffer and we may not want to alter input, or at least let the user choose).

layout

tpadioleau commented 9 months ago

Please identify in the set of dimensions {x, y, z} the dimension of interest and the dimensions of batching.

blegouix commented 3 months ago

Ginkgo or Lapack impose their layouts. Imo, the first rationnal thing to do would be bypassing the transpose if the dimension of interest is the "leftest" (contiguous for Lapack, coalescent for Ginkgo).

Going further would require handling layout stride internally in the matrixclasses, I think this is quite immediate with Kokkos-kernel backend but less easy with Ginkgo (slice according to the layout). In both cases this is not clear if it would be beneficial for performance.

I wait for the Lapack backend to be available before working on it.