Deprecate is_spline_interpolation_mesh_uniform

CExA-project / ddc

DDC is a discrete domain computation library.

https://ddc.mdls.fr

Other

28 stars 3 forks source link

Deprecate is_spline_interpolation_mesh_uniform #492

Open EmilyBourne opened 2 weeks ago

EmilyBourne commented 2 weeks ago

The function is_spline_interpolation_mesh_uniform does not make sense. It is described as: https://github.com/CExA-project/ddc/blob/b8ccaf41a5fa918146d968fb2e34096bc146c3a3/include/ddc/kernels/splines/spline_builder.hpp#L24-L35

However in reality it gives the uniform/non_uniform status of greville abcissae. The interpolation points have been decoupled from the greville abcissae for a while so this function should not be used. It should therefore be deprecated

EmilyBourne commented 2 weeks ago

This was discussed in https://github.com/CExA-project/ddc/pull/409/files#r1579627086

Following https://gitlab.maisondelasimulation.fr/gysela-developpers/gyselalibxx/-/merge_requests/511 this function is no longer used in Gysela

tpadioleau commented 1 week ago

Ok if it is no longer used then we will bypass the deprecating stage and remove it.