CExA-project / ddc

DDC is a discrete domain computation library.
https://ddc.mdls.fr
Other
33 stars 5 forks source link

Install the minimum of dependencies and build ginkgo in release #613

Closed tpadioleau closed 2 months ago

tpadioleau commented 2 months ago

As a general remark, I do not think it is a good idea to introduce conditional branches inside a Dockerfile for multiple backends. I would rather recommend to prepare multiple Dockerfiles for each backend. This way each Dockerfile is significantly easier to read and maintain.

As the images tend to diverge it could be worth dedicate separate files. I also notice that modifying a single backend triggers the build of all backends which is a bit annoying. I am not against but it is not in the scope of the current PR.

yasahi-hpc commented 2 months ago

As a general remark, I do not think it is a good idea to introduce conditional branches inside a Dockerfile for multiple backends. I would rather recommend to prepare multiple Dockerfiles for each backend. This way each Dockerfile is significantly easier to read and maintain.

As the images tend to diverge it could be worth dedicate separate files. I also notice that modifying a single backend triggers the build of all backends which is a bit annoying. I am not against but it is not in the scope of the current PR.

I agree that this is not the scope of this PR.

tpadioleau commented 2 months ago

@yasahi-hpc thank you for the review