search

CExA-project / ddc

DDC is a discrete domain computation library.
https://ddc.mdls.fr
Other
33 stars 5 forks source link

Use Kokkos 4.4.01 with mdspan coming from Kokkos #651

Closed tpadioleau closed 1 month ago

tpadioleau commented 1 month ago
  1. [x] update submodule Kokkos to version 4.4.01,
  2. [x] remove submodule mdspan,
  3. [x] change std::experimental::mdspan to Kokkos::mdspan,
  4. [x] convert potential layout_[left|right]_padded returned by submdspan to layout_stride,
  5. [x] Kokkos Kernels also needs to be updated, see with @yasahi-hpc

The reason I use the strategy 3. is that submdspan may return a layout_left_padded/layout_right_padded layout. Although these layouts should map to Kokkos LayoutLeft/LayoutRight, I could not find in Kokkos 4.4.01 any public API to construct a Kokkos layout with the padding value.

pzehner commented 1 month ago

I could not find in Kokkos 4.4.01 any public API to construct a Kokkos layout with the padding value.

@tpadioleau Did you open an issue on Kokkos about this?

tpadioleau commented 1 month ago

@tpadioleau Did you open an issue on Kokkos about this?

Not yet, we should do it at some point. It is not critical now that we have found a workaround.

tpadioleau commented 1 month ago

@acalloo do you still want to do a review or should I merge ?

Edit: Ansar is ok to merge