Add missing dependencies on installed DDC

tpadioleau commented 1 month ago

[x] declare missing dependencies in DDCConfig.cmake
[x] install missing FindLAPACKE.cmake, required by DDC when using splines
[x] add CI test

It seems to be working but could be further improved in future PR.

The headers related to fft, splines and the PDI wrapper of DDC are being installed whatever the values of the cmake options. I think it could improved with some reorganization.
Cmake targets about the fft and splines are missing.
We should look at cmake components. As long as the user can adapt it looks ok
```
find_package(DDC REQUIRED)
```

add_executable(main main.cpp) target_link_libraries(main PRIVATE DDC::DDC)

if(DDC_BUILD_PDI_WRAPPER) target_link_libraries(main PRIVATE DDC::PDI_Wrapper) endif()


but as soon as a user requires an option this looks bad
```cmake
find_package(DDC REQUIRED)

if(NOT DDC_BUILD_KERNELS_FFT)
    message(FATAL_ERROR "Expecting DDC_BUILD_KERNELS_FFT=ON")
endif()

DDC lacks a header configuration file to list enabled options. These are passed as "compile definition" but pollute the user side.

yasahi-hpc commented 3 weeks ago

If you added install_test, should you also apply format check to that directory?

https://github.com/CExA-project/ddc/blob/579427b92e6246a5c4e67a4bc16747e9f2624a96/.github/workflows/tests.yml#L19

tpadioleau commented 3 weeks ago

If you added install_test, should you also apply format check to that directory?

https://github.com/CExA-project/ddc/blob/579427b92e6246a5c4e67a4bc16747e9f2624a96/.github/workflows/tests.yml#L19

Indeed good catch

CExA-project / ddc

Add missing dependencies on installed DDC #665