Add rudementary backup recovery and discord rate limiting - Githubissues

CFC-Servers / cfc_err_forwarder

Send both server and client Gmod errors to your Discord channel

20 stars 1 forks source link

Add rudementary backup recovery and discord rate limiting #31

Closed brandonsturgeon closed 8 months ago

brandonsturgeon commented 1 year ago

This PR accomplishes two things:

Basic backup and recovery of the error queue, making it less likely that servers will lose errors in the event of a crash or restart (not perfect though).
Fully respect Discord rate limits

(Addresses #30)

Some notes:

`cfc_err_forwarder_interval` has been changed to `cfc_err_forwarder_dedupe_duration`. The setting is similar, but now has a more focused purpose, justifying a rename.

ErrorForwarder will not retry failed webhooks, it will simply log the failure and move on. My thinking is that servers typically have a reliable connection (the one exception being a message that's too long), so any issue causing requests to fail would likely cause all requests to fail. To that end, I'm not sure how useful retries will actually be.

brandonsturgeon commented 8 months ago

This will be added in https://github.com/CFC-Servers/cfc_err_forwarder/pull/33