search

CFCommunity / ramen

Integrated Installer for ColdFusion Servers
25 stars 10 forks source link

Adding Underscore.cfc for 24pullrequests.com #20

Closed russplaysguitar closed 11 years ago

russplaysguitar commented 11 years ago

Hope this is right!

russplaysguitar commented 11 years ago

Is there a way to specify CF 10 as a requirement for this package?

atuttle commented 11 years ago

There is not currently a way to specify a minimum CF version, but that would be another great feature to add. ;)

I'll log an issue for it. In the meantime, I'd just put it in the name/desc and try to make it obvious. Your install script could also check the CF version (server.coldfusion.version, I believe?) and refuse to install if it's < 10.

russplaysguitar commented 11 years ago

ok thanks, i'll have a look at getting that working before merging this in

atuttle commented 11 years ago

Cool beans. Your code as-is looks good (just update the name/desc in the index file to indicate CF10+, and/or add the version check in your install script).

Also just so you know, the "scriptless" installer covers the general case that you're implementing (download a zip, unzip it to user-specified location). You don't have to switch to it, and indeed if you intend to do a version check then (currently) you need to use a custom installer.

the more you know!

atuttle commented 11 years ago

Just waiting on your update to merge it in, btw.

russplaysguitar commented 11 years ago

okay, i did it the lazy way (for now)