CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
178 stars 70 forks source link

VTK and HDF5 output additions + cpu output fix #426

Closed bhill23 closed 1 year ago

bhill23 commented 1 year ago

Addresses #186. Region definition works similarly to Geometry definition, negative dx and nx work backwards from domain end. Also adds nodetypes to HDF5 outputs. Fixes outputs for cpu only builds where the z axis was not being looped over.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 71.42% and project coverage change: +0.18 :tada:

Comparison is base (3693cc7) 32.34% compared to head (19591a9) 32.52%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #426 +/- ## =========================================== + Coverage 32.34% 32.52% +0.18% =========================================== Files 154 152 -2 Lines 6425 6453 +28 =========================================== + Hits 2078 2099 +21 - Misses 4347 4354 +7 ``` | Flag | Coverage Δ | | |---|---|---| | d2q9 | `30.45% <71.42%> (+0.17%)` | :arrow_up: | | d2q9_bc | `26.73% <71.42%> (+0.21%)` | :arrow_up: | | d2q9_kuper | `27.58% <71.42%> (+0.21%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/CFD-GO/TCLB/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [src/Handlers/cbHDF5.cpp](https://codecov.io/gh/CFD-GO/TCLB/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2NiSERGNS5jcHA=) | `0.00% <0.00%> (ø)` | | | [src/Solver.h.Rt](https://codecov.io/gh/CFD-GO/TCLB/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL1NvbHZlci5oLlJ0) | `33.33% <ø> (ø)` | | | [src/cross.h](https://codecov.io/gh/CFD-GO/TCLB/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL2Nyb3NzLmg=) | `80.00% <ø> (ø)` | | | [src/hdf5Lattice.cpp.Rt](https://codecov.io/gh/CFD-GO/TCLB/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL2hkZjVMYXR0aWNlLmNwcC5SdA==) | `0.00% <0.00%> (ø)` | | | [src/Handlers/cbVTK.cpp](https://codecov.io/gh/CFD-GO/TCLB/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2NiVlRLLmNwcA==) | `78.04% <71.87%> (-14.26%)` | :arrow_down: | | [src/Solver.cpp.Rt](https://codecov.io/gh/CFD-GO/TCLB/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL1NvbHZlci5jcHAuUnQ=) | `58.38% <100.00%> (ø)` | | | [src/vtkLattice.cpp.Rt](https://codecov.io/gh/CFD-GO/TCLB/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL3Z0a0xhdHRpY2UuY3BwLlJ0) | `28.40% <100.00%> (+1.66%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://codecov.io/gh/CFD-GO/TCLB/pull/426/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

llaniewski commented 1 year ago

Fixes #186