CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
178 stars 70 forks source link

Solid Container #435

Closed llaniewski closed 1 year ago

llaniewski commented 1 year ago

Introducing new mechanics for Solid/Particle containers and iterating over particles. Additionally this PR cleans up the legacy mess with atomic reductions.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 82.70% and project coverage change: +1.48% :tada:

Comparison is base (9a06be7) 42.69% compared to head (cd760c9) 44.18%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #435 +/- ## =========================================== + Coverage 42.69% 44.18% +1.48% =========================================== Files 159 163 +4 Lines 7504 7777 +273 =========================================== + Hits 3204 3436 +232 - Misses 4300 4341 +41 ``` | Flag | Coverage Δ | | |---|---|---| | d2q9 | `30.44% <18.64%> (-0.16%)` | :arrow_down: | | d2q9_bc | `26.78% <15.25%> (-0.13%)` | :arrow_down: | | d2q9_kuper | `27.62% <16.66%> (-0.13%)` | :arrow_down: | | d3q27_PSM_NEBB | `35.73% <77.77%> (+0.06%)` | :arrow_up: | | d3q27_pf_velocity | `30.41% <22.58%> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [src/Handlers/cbRunR.cpp.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2NiUnVuUi5jcHAuUnQ=) | `66.66% <ø> (ø)` | | | [src/Lattice.h.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0xhdHRpY2UuaC5SdA==) | `64.28% <ø> (ø)` | | | [src/LatticeAccess.inc.cpp.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0xhdHRpY2VBY2Nlc3MuaW5jLmNwcC5SdA==) | `100.00% <ø> (ø)` | | | [src/LatticeContainer.h.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0xhdHRpY2VDb250YWluZXIuaC5SdA==) | `83.33% <ø> (ø)` | | | [src/LatticeContainer.inc.cpp.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0xhdHRpY2VDb250YWluZXIuaW5jLmNwcC5SdA==) | `63.40% <ø> (ø)` | | | [src/Particle.hpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL1BhcnRpY2xlLmhwcA==) | `64.70% <45.45%> (-15.05%)` | :arrow_down: | | [tests/solid/main.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-dGVzdHMvc29saWQvbWFpbi5jcHA=) | `70.10% <70.10%> (ø)` | | | [src/cross.h](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL2Nyb3NzLmg=) | `75.00% <75.00%> (-12.50%)` | :arrow_down: | | [src/SolidGrid.hpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL1NvbGlkR3JpZC5ocHA=) | `91.78% <91.78%> (ø)` | | | [models/particles/d3q27\_PSM/Dynamics.c.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-bW9kZWxzL3BhcnRpY2xlcy9kM3EyN19QU00vRHluYW1pY3MuYy5SdA==) | `31.66% <100.00%> (+0.38%)` | :arrow_up: | | ... and [7 more](https://app.codecov.io/gh/CFD-GO/TCLB/pull/435?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.