CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
180 stars 71 forks source link

Improved LatticeAccess #440

Closed llaniewski closed 1 year ago

llaniewski commented 1 year ago

This PR introduces new and improved LatticeAccess and Globals mechanism. It also unifies the way the thread-block sizes are chosen.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 32.60% and project coverage change: +4.86% :tada:

Comparison is base (cd760c9) 44.18% compared to head (7f1ad01) 49.04%. Report is 1 commits behind head on develop.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #440 +/- ## =========================================== + Coverage 44.18% 49.04% +4.86% =========================================== Files 163 130 -33 Lines 7777 4086 -3691 =========================================== - Hits 3436 2004 -1432 + Misses 4341 2082 -2259 ``` | Flag | Coverage Δ | | |---|---|---| | d2q9 | `28.98% <29.54%> (-1.47%)` | :arrow_down: | | d2q9_bc | `29.09% <29.54%> (+2.30%)` | :arrow_up: | | d2q9_kuper | `29.15% <29.54%> (+1.52%)` | :arrow_up: | | d3q27_PSM_NEBB | `43.20% <31.11%> (+7.46%)` | :arrow_up: | | d3q27_pf_velocity | `28.26% <31.11%> (-2.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/CFD-GO/TCLB/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [src/main.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL21haW4uY3Bw) | `68.68% <ø> (ø)` | | | [src/GetThreads.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0dldFRocmVhZHMuY3Bw) | `11.53% <11.53%> (ø)` | | | [src/GetThreads.h](https://app.codecov.io/gh/CFD-GO/TCLB/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0dldFRocmVhZHMuaA==) | `38.46% <38.46%> (ø)` | | | [src/cross.h](https://app.codecov.io/gh/CFD-GO/TCLB/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL2Nyb3NzLmg=) | `70.00% <100.00%> (-5.00%)` | :arrow_down: | | [src/range\_int.hpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL3JhbmdlX2ludC5ocHA=) | `100.00% <100.00%> (ø)` | | ... and [36 files with indirect coverage changes](https://app.codecov.io/gh/CFD-GO/TCLB/pull/440/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.