Closed llaniewski closed 1 year ago
Patch coverage has no change and project coverage change: -0.02%
:warning:
Comparison is base (
07dd2b9
) 44.10% compared to head (55c4849
) 44.08%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I added feature for plotting the stages and their access to a pdf file. The plot shows the field read and write status and marks problems in red. When you run
make d3q27_pf_velocity/summary
this nice plot is generated:
FYI: @TravisMitchell @shkodm @mdzik
This PR introduces a new mechanism for setting and testing the access policy for fields in stages.
Setting access
The
AddStage
has now three arguments:load.densities=
specifies theDensities
that are loaded at the beginning of the stage.read.fields=
specifies theFields
that can be accessed in the Dynamics withfield(dx,dy,dz)
macros.save.fields=
specifies theFields
that are saved at the end of the stage.Defaults
By default the actions/stages setup is:
Moreover, the default
read.fields
is as allowing as possible. If not specified otherwise it is assumed that stage has read access to all fields that are available to it.Checks
The access policies are checked in each
Action
(series ofStages
) assuming:Init
action should not read anything from previous iteration.Exceptions
There are three mechanisms to circumvent checks:
non.mandatory=TRUE
inAddField
signals that this field doesn't have to be written by the end of an actioncan.overwrite=TRUE
inAddStage
signals that a stage can overwrite fieldsSetOptions(permissive.access=TRUE)
switches the test entirely and sets all fields to be readable in all stages. This should be avoidedModifications
Some adjustments were made to models to agree with these policies. All models were tested and
permissive.access=TRUE
was added to the ones failing from this change. These models should be fixed to accommodate these checks. Especiallyd3q27_pf_velocity
, as per #437.