CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
178 stars 70 forks source link

Reduction of the use of rtemplate #445

Closed llaniewski closed 1 year ago

llaniewski commented 1 year ago

This PR introduces a "Model" abstract class which provides all model related data.frames in C++ containers that are easy to iterate over. This allows for all Handlers, and some other parts of code to not rely on rtemplate code generation to function.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 43.25% and project coverage change: +0.21% :tada:

Comparison is base (826ebf4) 44.08% compared to head (a7659dc) 44.30%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #445 +/- ## =========================================== + Coverage 44.08% 44.30% +0.21% =========================================== Files 166 169 +3 Lines 7821 7887 +66 =========================================== + Hits 3448 3494 +46 - Misses 4373 4393 +20 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `30.38% <33.48%> (-0.17%)` | :arrow_down: | | [d2q9_bc](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `26.67% <25.38%> (-0.14%)` | :arrow_down: | | [d2q9_kuper](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `27.44% <30.98%> (-0.07%)` | :arrow_down: | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `36.00% <36.95%> (+0.28%)` | :arrow_up: | | [d3q27_pf_velocity](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `30.44% <36.73%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [src/Handlers/BSpline.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL0JTcGxpbmUuY3Bw) | `0.00% <ø> (ø)` | | | [src/Handlers/IfContainer.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL0lmQ29udGFpbmVyLmNwcA==) | `0.00% <0.00%> (ø)` | | | [src/Handlers/IfContainer.h](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL0lmQ29udGFpbmVyLmg=) | `0.00% <ø> (ø)` | | | [src/Handlers/OptimalControl.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL09wdGltYWxDb250cm9sLmNwcA==) | `0.00% <0.00%> (ø)` | | | [src/Handlers/OptimalControlSecond.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL09wdGltYWxDb250cm9sU2Vjb25kLmNwcA==) | `0.00% <0.00%> (ø)` | | | [src/Handlers/acObjective.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2FjT2JqZWN0aXZlLmNwcA==) | `0.00% <0.00%> (ø)` | | | [src/Handlers/acOptimize.cpp.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2FjT3B0aW1pemUuY3BwLlJ0) | `26.66% <ø> (ø)` | | | [src/Handlers/acRunAction.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2FjUnVuQWN0aW9uLmNwcA==) | `0.00% <0.00%> (ø)` | | | [src/Handlers/acThreshold.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2FjVGhyZXNob2xkLmNwcA==) | `0.00% <0.00%> (ø)` | | | [src/Handlers/acThresholdNow.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2FjVGhyZXNob2xkTm93LmNwcA==) | `0.00% <0.00%> (ø)` | | | ... and [31 more](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/CFD-GO/TCLB/pull/445/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.