search

CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
180 stars 71 forks source link

Weird global state, possibly left over test code? #459

Open kubagalecki opened 12 months ago

kubagalecki commented 12 months ago

@llaniewski Can we get rid of this? It seems like xml_def is only used in the geometry stuff, can I confine it to that part?

https://github.com/CFD-GO/TCLB/blob/57dd196fde5688f33f98e285a5be09439486f0b6/src/main.cpp#L252

llaniewski commented 12 months ago

I think you can move it now, and later I can get rid of it entirely. It doesn't really do much and what it does can be solved differently.