search

CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
180 stars 71 forks source link

Refactor in preparation for arbitrary grid #460

Closed kubagalecki closed 11 months ago

kubagalecki commented 11 months ago
codecov-commenter commented 11 months ago

Codecov Report

Attention: 375 lines in your changes are missing coverage. Please review.

Comparison is base (57dd196) 44.52% compared to head (5fe9440) 44.45%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #460 +/- ## =========================================== - Coverage 44.52% 44.45% -0.07% =========================================== Files 169 169 Lines 7879 7870 -9 =========================================== - Hits 3508 3499 -9 Misses 4371 4371 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `30.47% <45.42%> (-0.21%)` | :arrow_down: | | [d2q9_bc](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `26.75% <44.26%> (-0.21%)` | :arrow_down: | | [d2q9_kuper](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `27.56% <44.85%> (-0.21%)` | :arrow_down: | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `36.07% <52.26%> (-0.16%)` | :arrow_down: | | [d3q27_pf_velocity](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `30.59% <44.88%> (-0.19%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [src/CartConnectivity.hpp.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0NhcnRDb25uZWN0aXZpdHkuaHBwLlJ0) | `100.00% <100.00%> (ø)` | | | [src/Geometry.cpp.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0dlb21ldHJ5LmNwcC5SdA==) | `33.15% <100.00%> (+2.16%)` | :arrow_up: | | [src/Global.cpp.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0dsb2JhbC5jcHAuUnQ=) | `47.16% <ø> (-3.71%)` | :arrow_down: | | [src/Global.h.Rt](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0dsb2JhbC5oLlJ0) | `100.00% <ø> (ø)` | | | [src/Handlers/InternalTopology.h](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL0ludGVybmFsVG9wb2xvZ3kuaA==) | `0.00% <ø> (ø)` | | | [src/Handlers/MainContainer.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL01haW5Db250YWluZXIuY3Bw) | `100.00% <100.00%> (ø)` | | | [src/Handlers/acGeometry.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2FjR2VvbWV0cnkuY3Bw) | `87.50% <100.00%> (+0.83%)` | :arrow_up: | | [src/Handlers/acModel.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2FjTW9kZWwuY3Bw) | `100.00% <100.00%> (ø)` | | | [src/Handlers/acParam.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2FjUGFyYW0uY3Bw) | `74.28% <100.00%> (ø)` | | | [src/Handlers/cbFailcheck.cpp](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#diff-c3JjL0hhbmRsZXJzL2NiRmFpbGNoZWNrLmNwcA==) | `75.43% <100.00%> (+0.43%)` | :arrow_up: | | ... and [55 more](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/CFD-GO/TCLB/pull/460/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

llaniewski commented 11 months ago

Please try this rewrite: https://github.com/llaniewski/TCLB/blob/feature/conversion/src/compare.cpp

llaniewski commented 11 months ago

One of the tests hanged completely, and I had to kill it: https://github.com/CFD-GO/TCLB/actions/runs/6778446673/job/18423924538?pr=460

llaniewski commented 11 months ago

I placed the old unstable branch in old-unstable, and I will make the new unstable branch from this work, so we can both contribute to it.