CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
178 stars 70 forks source link

Arbitrary grid #462

Closed kubagalecki closed 9 months ago

kubagalecki commented 9 months ago
codecov-commenter commented 9 months ago

Codecov Report

Attention: 1243 lines in your changes are missing coverage. Please review.

Comparison is base (85ab8ef) 44.45% compared to head (4dbf028) 36.63%. Report is 4 commits behind head on unstable.

Files Patch % Lines
src/ArbLattice.cpp 0.00% 431 Missing :warning:
src/LatticeBase.cpp.Rt 23.83% 131 Missing :warning:
src/toArb.cpp 0.00% 126 Missing :warning:
src/vtkLattice.cpp 24.17% 69 Missing :warning:
src/vtuOutput.cpp 0.00% 61 Missing :warning:
src/ArbLatticeLauncher.hpp.Rt 0.00% 53 Missing :warning:
src/Handlers/acUSAdjoint.cpp 6.12% 46 Missing :warning:
src/CartLattice.cpp.Rt 39.68% 38 Missing :warning:
src/main.cpp 68.42% 30 Missing :warning:
src/Handlers/acRunAction.cpp 0.00% 27 Missing :warning:
... and 31 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## unstable #462 +/- ## ============================================ - Coverage 44.45% 36.63% -7.82% ============================================ Files 169 182 +13 Lines 7878 8096 +218 ============================================ - Hits 3502 2966 -536 - Misses 4376 5130 +754 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/462/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `26.69% <22.74%> (-3.79%)` | :arrow_down: | | [d2q9_bc](https://app.codecov.io/gh/CFD-GO/TCLB/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `23.46% <21.80%> (-3.30%)` | :arrow_down: | | [d2q9_kuper](https://app.codecov.io/gh/CFD-GO/TCLB/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `24.26% <22.24%> (-3.33%)` | :arrow_down: | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `31.84% <21.97%> (-4.24%)` | :arrow_down: | | [d3q27_pf_velocity](https://app.codecov.io/gh/CFD-GO/TCLB/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kubagalecki commented 9 months ago

@llaniewski As seen in https://github.com/CFD-GO/TCLB/actions/runs/6926854681/job/18839682950, there was a bug in determining unique directions. I've now fixed it, but it exposed a limitation of HIP: the maximum number of unique offset directions is 256, e.g. d3q343 would not compile. This is a result of a low limit of fold expression expansions in clang, see minimum example. There is a way to work around this by writing more R template code, but the question is do we realistically need to support models with q > 256?

kubagalecki commented 9 months ago

There is a way to work around this by writing more R template code

There is also a compiler flag -fbracket-depth=N to raise the limit