search

CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
178 stars 70 forks source link

Program logic within `assert` statements #465

Open kubagalecki opened 9 months ago

kubagalecki commented 9 months ago

See e.g.:

https://github.com/CFD-GO/TCLB/blob/323924b1e284de04ecb76bd890956ffdd3a83b6a/src/cross.h#L250

Program logic should not depend on the contents of assert statements, since they will be #ifdefed out in a release (-DNDEBUG) build. This happens in multiple places in the code.