CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
177 stars 70 forks source link

Correcting error in arbitrary grid partition #467

Closed llaniewski closed 8 months ago

llaniewski commented 8 months ago

This corrects the row sorting of the parmetis graph, which caused wrong connectivity after partition.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 1259 lines in your changes are missing coverage. Please review.

Comparison is base (3025671) 44.45% compared to head (7a6f0e3) 36.55%. Report is 51 commits behind head on unstable.

Files Patch % Lines
src/ArbLattice.cpp 0.00% 438 Missing :warning:
src/LatticeBase.cpp.Rt 23.83% 131 Missing :warning:
src/toArb.cpp 0.00% 126 Missing :warning:
src/vtkLattice.cpp 24.17% 69 Missing :warning:
src/vtuOutput.cpp 0.00% 61 Missing :warning:
src/ArbLatticeLauncher.hpp.Rt 0.00% 53 Missing :warning:
src/Handlers/acUSAdjoint.cpp 6.12% 46 Missing :warning:
src/CartLattice.cpp.Rt 39.68% 38 Missing :warning:
src/ArbConnectivity.hpp 0.00% 34 Missing :warning:
src/main.cpp 68.42% 30 Missing :warning:
... and 31 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## unstable #467 +/- ## ============================================ - Coverage 44.45% 36.55% -7.91% ============================================ Files 169 182 +13 Lines 7878 8112 +234 ============================================ - Hits 3502 2965 -537 - Misses 4376 5147 +771 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `26.64% <22.52%> (-3.84%)` | :arrow_down: | | [d2q9_bc](https://app.codecov.io/gh/CFD-GO/TCLB/pull/467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `23.41% <21.59%> (-3.35%)` | :arrow_down: | | [d2q9_kuper](https://app.codecov.io/gh/CFD-GO/TCLB/pull/467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `24.19% <22.02%> (-3.39%)` | :arrow_down: | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `31.77% <21.76%> (-4.30%)` | :arrow_down: | | [d3q27_pf_velocity](https://app.codecov.io/gh/CFD-GO/TCLB/pull/467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.