Closed llaniewski closed 8 months ago
I was already okay with removing native Python support but this also looks nice :).
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4e28d4e
) 44.30% compared to head (e096d7d
) 44.30%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Very exciting, thanks @llaniewski ! Do you want me to test it using the two-phase fracture setup I was working on?
@shkodm I think I would like you to test on the fracture setup, and maybe add to the multiphase tools repo as a demo for using it ;)
@shkodm That would be great. Hope this will simplify your setup a bit. edit: Of course, after you come back to the office.
@TravisMitchell @shkodm Some notes:
Solver
object doesn't really work well (eg. Solver.Geometry.BOUNDARY[0,0] = "None"
). I think this would mean much more effort.@llaniewski I tested, and it seems to work for my purposes now (plotting phase field on the aperture plot). We can probably merge this one directly now and then create follow up PRs if I find some issues.
Regarding notes:
This PR extends the RunR capabilities with Python execution through the
reticulate
. You can now execute Python code with<RunPython/>
element, whereSolver
is exposed in the same way as in R.Example
FYI: @TravisMitchell @shkodm @mdzik I think with this present in the code we can get rid of the native Python support.