CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
184 stars 72 forks source link

Arb fix/d2q9 pf velocity #471

Closed TravisMitchell closed 11 months ago

TravisMitchell commented 11 months ago

this initial fix at least allows the d2q9 phase field model to be run with normal cases. There is a chance that very complex geometry may cause edge conditions (e.g. where a solid node has a normal direction that points to another solid) that may require the introduction of a new field in the future.

Note that use of nan makes failcheck require to be applied with a focus area.

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7a6f0e3) 36.55% compared to head (f05a11b) 38.09%. Report is 19 commits behind head on unstable.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## unstable #471 +/- ## ============================================ + Coverage 36.55% 38.09% +1.54% ============================================ Files 182 185 +3 Lines 8112 8355 +243 ============================================ + Hits 2965 3183 +218 - Misses 5147 5172 +25 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/471/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/471/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `26.64% <ø> (ø)` | | | [d2q9_bc](https://app.codecov.io/gh/CFD-GO/TCLB/pull/471/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `23.41% <ø> (ø)` | | | [d2q9_kuper](https://app.codecov.io/gh/CFD-GO/TCLB/pull/471/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `24.19% <ø> (ø)` | | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/471/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `31.77% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.