CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
177 stars 70 forks source link

Fix minor bug in last pull request for d2q9_pf_velocity #474

Closed TravisMitchell closed 8 months ago

TravisMitchell commented 8 months ago

Sorry, silly mistake in re-jig of isotropic difference stencil. I didn't include 4/9 weight in denom so altered interaction.

This will be outside tolerance of master tests, as the use of this weighted gradient stencil has a very minor impact on results. However, this weighted average is a better option compared to previous which was using phase values inside of the solid that would have been set at initialisation.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f05a11b) 38.09% compared to head (1e67f65) 38.09%. Report is 22 commits behind head on unstable.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## unstable #474 +/- ## ========================================= Coverage 38.09% 38.09% ========================================= Files 185 185 Lines 8355 8355 ========================================= Hits 3183 3183 Misses 5172 5172 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/474/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `26.64% <ø> (ø)` | | | [d2q9_bc](https://app.codecov.io/gh/CFD-GO/TCLB/pull/474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `23.41% <ø> (ø)` | | | [d2q9_kuper](https://app.codecov.io/gh/CFD-GO/TCLB/pull/474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `24.19% <ø> (ø)` | | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `31.77% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.