search

CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
177 stars 70 forks source link

Corrections for uninitialised fields in d3q27_pf_velocity #479

Closed llaniewski closed 7 months ago

llaniewski commented 7 months ago

This fixes the problem of uninitialised values in the InitFromFieldsStage stage.

@shkodm Could you make it a priority to test if this doesn't break your computations?

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9d3bd18) 43.23% compared to head (0deb2fb) 89.08%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #479 +/- ## =========================================== + Coverage 43.23% 89.08% +45.84% =========================================== Files 166 6 -160 Lines 7535 348 -7187 =========================================== - Hits 3258 310 -2948 + Misses 4277 38 -4239 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/479/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/479/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/479/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | | [d3q27_pf_velocity](https://app.codecov.io/gh/CFD-GO/TCLB/pull/479/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shkodm commented 7 months ago

It seems that breaks something... I am investigating now

shkodm commented 7 months ago

It seems that breaks something... I am investigating now

Never mind, everything seems to be working fine. Tested on the actual fracture case I am running and compare visualisation. Should be good to merge