CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
177 stars 70 forks source link

Small mods to stl import to make it more robust #491

Closed llaniewski closed 7 months ago

llaniewski commented 7 months ago

It would be good to have some tests for STL.

FYI @TravisMitchell

codecov-commenter commented 7 months ago

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (16ab637) 39.66% compared to head (77fb8e0) 30.88%.

Files Patch % Lines
src/Geometry.cpp 0.00% 45 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #491 +/- ## =========================================== - Coverage 39.66% 30.88% -8.79% =========================================== Files 184 180 -4 Lines 8471 7606 -865 =========================================== - Hits 3360 2349 -1011 - Misses 5111 5257 +146 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/491/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `28.00% <0.00%> (-0.03%)` | :arrow_down: | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | | [d3q27_pf_velocity](https://app.codecov.io/gh/CFD-GO/TCLB/pull/491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.