Closed shkodm closed 7 months ago
Could you verify also if things that are recommended for install here: https://github.com/CFD-GO/TCLB/blob/master/tools/install.sh#L292 are in tune with what you have?
Also, I remember other people running TCLB on mac needed some paths changed, and back then I wrote this: https://github.com/CFD-GO/TCLB/blob/master/tools/env.sh Is this still needed?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f7f36f7
) 35.14% compared to head (6024214
) 39.63%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Also, I remember other people running TCLB on mac needed some paths changed, and back then I wrote this: https://github.com/CFD-GO/TCLB/blob/master/tools/env.sh Is this still needed?
I did not use it. Both in the script and in the tools/install.sh
, gnu-sed
and findutils
are not needed, because macOS already ships those tools by default, and it is better not have random conflicts between them
Could you verify also if things that are recommended for install here: https://github.com/CFD-GO/TCLB/blob/master/tools/install.sh#L292 are in tune with what you have?
I installed using the install.sh
(and have all the packages that are installed there), but taking into the account the notice above. I don't think I did anything extra. When @TravisMitchell is going to install, he can verify.
Thanks @shkodm, it will be a couple weeks before I get the chance to test (lead time is on my mac is a bit slow) - but will let you know if anything else is needed for this.
Supersedes #493
-E
in sed to be POSIX compliantfind
to make it more tolerable and portablefind models/
produces extra slashes in results on macos ( i.e.models//multiphase/
) but not on Linux.find models
does not give extra slashes and behaves the same asfind models/
on modelsTested on my M2 Macbook Air, all the clusters where I use TCLB, and my workstation.
@TravisMitchell FYI
I will also CI at some point, but not in this PR.