search

CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
183 stars 72 forks source link

Add fixes for building on macOS #495

Closed shkodm closed 10 months ago

shkodm commented 10 months ago

Supersedes #493

Tested on my M2 Macbook Air, all the clusters where I use TCLB, and my workstation.

@TravisMitchell FYI

I will also CI at some point, but not in this PR.

llaniewski commented 10 months ago

Could you verify also if things that are recommended for install here: https://github.com/CFD-GO/TCLB/blob/master/tools/install.sh#L292 are in tune with what you have?

Also, I remember other people running TCLB on mac needed some paths changed, and back then I wrote this: https://github.com/CFD-GO/TCLB/blob/master/tools/env.sh Is this still needed?

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f7f36f7) 35.14% compared to head (6024214) 39.63%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #495 +/- ## ========================================== + Coverage 35.14% 39.63% +4.48% ========================================== Files 162 161 -1 Lines 6621 7178 +557 ========================================== + Hits 2327 2845 +518 - Misses 4294 4333 +39 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/495/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/495/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/495/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `36.53% <ø> (?)` | | | [d3q27_pf_velocity](https://app.codecov.io/gh/CFD-GO/TCLB/pull/495/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `30.91% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shkodm commented 10 months ago

Also, I remember other people running TCLB on mac needed some paths changed, and back then I wrote this: https://github.com/CFD-GO/TCLB/blob/master/tools/env.sh Is this still needed?

I did not use it. Both in the script and in the tools/install.sh, gnu-sed and findutils are not needed, because macOS already ships those tools by default, and it is better not have random conflicts between them

Could you verify also if things that are recommended for install here: https://github.com/CFD-GO/TCLB/blob/master/tools/install.sh#L292 are in tune with what you have?

I installed using the install.sh (and have all the packages that are installed there), but taking into the account the notice above. I don't think I did anything extra. When @TravisMitchell is going to install, he can verify.

TravisMitchell commented 10 months ago

Thanks @shkodm, it will be a couple weeks before I get the chance to test (lead time is on my mac is a bit slow) - but will let you know if anything else is needed for this.