Closed bhill23 closed 6 months ago
Attention: 16 lines
in your changes are missing coverage. Please review.
Comparison is base (
662f81b
) 44.27% compared to head (43567db
) 44.24%.
Files | Patch % | Lines |
---|---|---|
src/Geometry.cpp.Rt | 0.00% | 16 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The main loop for the sweep was unnecessarily repeating the spline calculation, and also looping over regions unnecessarily large. A very simple 'adaptive' step is also added, and the distance calculation brought into line with the other geometry types (pipes/spheres/etc) with the 0.5 offset, so the sweep can be combined smoothly with the other types.