CFD-GO / TCLB

TCLB - Templated MPI+CUDA/CPU Lattice Boltzmann code
https://tclb.io
GNU General Public License v3.0
177 stars 70 forks source link

Fixed to the phase-field model #515

Open shkodm opened 2 months ago

shkodm commented 2 months ago

Synchronising various fixes I did to the phase-field mode over the past months:

Pressure boundary conditions fixes:

Now doing some testing to make sure I did not mess up when refactoring. So draft PR for now. cc @TravisMitchell

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.36%. Comparing base (2362a9d) to head (98accf4). Report is 24 commits behind head on master.

:exclamation: Current head 98accf4 differs from pull request most recent head 9a0f8d6

Please upload reports for the commit 9a0f8d6 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #515 +/- ## ========================================== - Coverage 44.24% 36.36% -7.89% ========================================== Files 166 159 -7 Lines 7567 6790 -777 ========================================== - Hits 3348 2469 -879 - Misses 4219 4321 +102 ``` | [Flag](https://app.codecov.io/gh/CFD-GO/TCLB/pull/515/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | Coverage Δ | | |---|---|---| | [d2q9](https://app.codecov.io/gh/CFD-GO/TCLB/pull/515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | | [d3q27_PSM_NEBB](https://app.codecov.io/gh/CFD-GO/TCLB/pull/515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `36.36% <ø> (+0.01%)` | :arrow_up: | | [d3q27_pf_velocity](https://app.codecov.io/gh/CFD-GO/TCLB/pull/515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CFD-GO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shkodm commented 2 months ago

@nparaskevas you can test it now if you want. I provided the description of different boundary conditions variants in the PR description. Just using WPressure on the inlet and EPressurefflux or EPressurefpf or EPressureopen on the outlet would work, but you should play around.

Don't forget to add InvasionDrainage value="2" to the setting in case of drainage, or value = 1 in case of invasion