Open shkodm opened 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 36.36%. Comparing base (
2362a9d
) to head (98accf4
). Report is 24 commits behind head on master.:exclamation: Current head 98accf4 differs from pull request most recent head 9a0f8d6
Please upload reports for the commit 9a0f8d6 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@nparaskevas you can test it now if you want. I provided the description of different boundary conditions variants in the PR description. Just using WPressure
on the inlet and EPressurefflux
or EPressurefpf
or EPressureopen
on the outlet would work, but you should play around.
Don't forget to add InvasionDrainage value="2"
to the setting in case of drainage, or value = 1
in case of invasion
Synchronising various fixes I did to the phase-field mode over the past months:
Pressure boundary conditions fixes:
Now use proper ZouHe boundary conditions, with 3 variants. (Some can be removed later)
fflux
enforces constant flux -> Breaks when interface enters the outlet - default (i.e withWPressure
orEPRessure
name)EPressurefpf
) makes sure the inlet / outlet phase-field is the same as specified (i.e. sum of distributions forced to be equal to it). Effect: interface propagation stop at the outlet, "impossible-to-displace liquid". But seems to not work with the inletopen
suffix (i.e. EPressureopen) does not enforce the phase-field. Interface propagates into the outlet, splits in 2, there are so strange effects, but otherwise does not look too crazyInvasionDrainage
is non-zero. And when the boundary conditions are the first / last layers of the domain. Otherwise, one has to compile the model withautosym
option, and mark the inlet / oulets with Symmetry boundaries, so that the periodicity is switched offInvasionDrainage
marks if the case is drainage (non-wetting displacing wetting), or invasion (wetting displacing non-wetting). This sets some densities and phase-field on the inlet / outletMerging with master, because I (and I think other people who are using phase-field model are mostly using master branch and the fixes are quite crucial)
Now doing some testing to make sure I did not mess up when refactoring. So draft PR for now. cc @TravisMitchell