search

CFIA-NCFAD / wgscovplot

The Whole Genome Sequencing Coverage Plot (wgscovplot) is a tool to generate HTML Interactive Coverage Plot given coverage depth information, variants and DNA Gene features
Other
17 stars 6 forks source link

Non-dev JS dependencies? #30

Closed peterk87 closed 2 years ago

peterk87 commented 2 years ago

The devDependencies are listed in the package.json, but where are the other dependencies?

https://github.com/nhhaidee/wgscovplot/blob/master/package.json

Both Lodash and ECharts should be regular dependencies https://github.com/nhhaidee/wgscovplot/blob/d73b55e4fedb8b8b5a9056e502f0e6b61b76ebe1/package.json#L30 https://github.com/nhhaidee/wgscovplot/blob/d73b55e4fedb8b8b5a9056e502f0e6b61b76ebe1/package.json#L32

Select2, jQuery and Bootstrap are missing from package.json.

nhhaidee commented 2 years ago

@peterk87: updated by PR https://github.com/nhhaidee/wgscovplot/pull/33