search

CFMIP / COSPv2.0

COSP - The CFMIP (Cloud Feedbacks Model Intercomparison Project) Observation Simulator Package
42 stars 40 forks source link

Use CI test script for off-line tests. #45

Closed alejandrobodas closed 4 years ago

alejandrobodas commented 4 years ago

Currently, the CI tests and the off-line tests use different python scripts. This request simplifies the approach by changing the off-line tests instructions so that they use the script cosp2_test_01.py, use by the CI tests. This only involves changing the instructions and removing the old script and reference files. It also modifies cosp2_test_01.py to make the error/success messages colour-coded. This pull request addresses issue #43.

RobertPincus commented 4 years ago

@alejandrobodas Thanks for doing this. Just one comment - "cosp2_test_01" is sort of an obscure name for the testing script. "compare_to_reference?" We'd be better off, I think, being a bit more clear.

RobertPincus commented 4 years ago

PS "compare_to_reference" is a name I use but it's a very mild suggestion, if you have another name you like better .

RobertPincus commented 4 years ago

@alejandrobodas Thanks a lot, this seems perfect. I encourage you to merge onto master and close #43

alejandrobodas commented 4 years ago

@RobertPincus Thanks for the quick review.