Bugfix in dimID index for REICE_MODIS

CFMIP / COSPv2.0

COSP - The CFMIP (Cloud Feedbacks Model Intercomparison Project) Observation Simulator Package

42 stars 40 forks source link

Bugfix in dimID index for REICE_MODIS #58

Closed alejandrobodas closed 3 years ago

alejandrobodas commented 3 years ago

Minor bug reported by Po-Lun. Wrong index in cosp2_io.f90. This was reported some time ago, but the intel CI test failed (due to issues in the CI test itself). We should be able to fix the CI test if github has updated ubuntu 18.04.

alejandrobodas commented 3 years ago

Hi @RobertPincus , would you mind reviewing these changes? The fortran change is a one-liner, but there are a few changes in the integration test. I have incorporated the changes in #57. The upgrade to Ubuntu 20.04 breaks bit-comparability between gfortran-9 and previous versions, so I had to use a method similar to the one used for ifort in the comparisons against the KGO. Thanks!

alejandrobodas commented 3 years ago

@RobertPincus , thank you very much for your quick review. I've addressed your comments and all tests have passed, so I'm merging this pull request.