search

CFMIP / COSPv2.0

COSP - The CFMIP (Cloud Feedbacks Model Intercomparison Project) Observation Simulator Package
41 stars 38 forks source link

Bugfix warmrain diagnostics r02 #73

Closed dustinswales closed 2 years ago

dustinswales commented 2 years ago

Reopening after accidentally close #70

dustinswales commented 2 years ago

@alejandrobodas Sorry for making a mess of the repo. (I thought I was pushing to my forked repo. Sorry) @takmichibata Before you do any of the updating to the CI files mentioned by Alejandro, you need to update your code. In your branch,

git remote add CFMIP https://github.com/CFMIP/COSPv2.0.git git pull CFMIP master

This will pull in any changes that you need to build on top of.

alejandrobodas commented 2 years ago

@dustinswales no worries, thanks for reverting the master to the original state.

takmichibata commented 2 years ago

@dustinswales Thanks for your suggestion! I pulled the CFMIP master code into my repository. @alejandrobodas The first CI test passed through but the gfortran-8 test failed. The error message; diff: data/outputs/UKMO/cosp2_output.um_global.gfortran-8.kgo.v002.out: No such file or directory It seemed that the reference KGO file was not found. Do you have any idea what it is?

alejandrobodas commented 2 years ago

Hi @takmichibata . Different compilers give slightly different results, but we don't use NetCDF files as KGOs for each compiler. Instead, we use a text file that records a summary of differences between the NetCDF outputs with different compilers. In the artifact created by this CI (outputs.UKMO.tgz) there is a file called 'cosp2_output.um_global.out'. If you add that file to your branch as 'driver/data/outputs/UKMO/cosp2_output.um_global.gfortran-8.kgo.v002.out' the test should pass. I'm afraid you'll have to repeat the same process for the gfortran-7 and ifort tests, adapting the name of the files. Thanks again for your patience!

takmichibata commented 2 years ago

@alejandrobodas I understood the procedure. The CI test now seems to go well. Thanks for your support.

alejandrobodas commented 2 years ago

@takmichibata that looks great, I've merged the changes. Thanks!