search

CFMIP / COSPv2.0

COSP - The CFMIP (Cloud Feedbacks Model Intercomparison Project) Observation Simulator Package
42 stars 40 forks source link

Allocation of radar LUT. Delete unused variables. Update ifort KGO v002. #77

Closed alejandrobodas closed 1 year ago

alejandrobodas commented 1 year ago

Something must have changed in the ifort compiler which makes the ifort test to fail. This PR updates the KGO file for the test that fails.

alejandrobodas commented 1 year ago

@dustinswales @RobertPincus this change is trivial, it fixes the CI tests before a minor change to the fortran code that I will be submit soon.

dustinswales commented 1 year ago

@alejandrobodas Is this because we didn't update the KGOs after #75?

alejandrobodas commented 1 year ago

@dustinswales I don't think so, the log shows that #75 passed the tests, so I think something has changed under the hood in the intel oneapi that has caused small differences in the outputs. It must have been in the last 3 months, since your update to the readme. This has happened before, it's a nuisance that we have to deal with from time to time.

alejandrobodas commented 1 year ago

@dustinswales @RobertPincus I've expanded the scope of this change to include a few minor changes that don't change the KGOs. These changes originate from the implementation of COSP2 in LFRic (the model that will replace the UM).

alejandrobodas commented 1 year ago

Hi @dustinswales , are you happy with the latest version changes? If so, can I go ahead and merge?

dustinswales commented 1 year ago

Hi @alejandrobodas. Sorry for the delay. No objections from me. Merged.

alejandrobodas commented 1 year ago

Great, thanks @dustinswales . I've deleted the branch.