search

CFMIP / COSPv2.0

COSP - The CFMIP (Cloud Feedbacks Model Intercomparison Project) Observation Simulator Package
41 stars 38 forks source link

download_test_data.sh drive links #83

Closed caseywall7926 closed 2 months ago

caseywall7926 commented 4 months ago

We tried to follow the instructions for running the offline tests in the README file, and it seems that the links in the download_test_data.sh are outdated. When running compare_to_kgo.py we got the following error:

===== ERROR: some of the differences are larger than the tolerances.
==========================================  Summary statistics  ==========================================
                                Variable          N      AvgDiff      MinDiff      MaxDiff        StDev
                                 npdfcld         47  -1.0000e+00  -1.0000e+00  -1.0000e+00   0.0000e+00
                                 npdfdrz         47  -1.0000e+00  -1.0000e+00  -1.0000e+00   0.0000e+00
                                npdfrain         47  -1.0000e+00  -1.0000e+00  -1.0000e+00   0.0000e+00
                                 ncfodd1      35250  -1.0000e+00  -1.0000e+00  -1.0000e+00   0.0000e+00
                                 ncfodd2      35250  -1.0000e+00  -1.0000e+00  -1.0000e+00   0.0000e+00
                                 ncfodd3      35250  -1.0000e+00  -1.0000e+00  -1.0000e+00   0.0000e+00
==========================================================================================================
===== ERROR: the test is exiting with an error, please review the output above.

And judging by the links used in the continuous_integration.yml the links in the download script are at least one year older. Should we make a PR with fix?

dustinswales commented 4 months ago

@caseywall7926 Thanks for bringing this to our attention. If you have a fix that you would like to contribute back, then it would be fantastic if you could open a PR here for us to review.

mvdebolskiy commented 4 months ago

Also, I've noticed, there is no .gitignore is this on purpose? Since git status will just dump all the .o .a .mod files, cosp2_test and all the .nc files, etc.

mvdebolskiy commented 2 months ago

This can be closed.