search

CFMTech / pytest-monitor

Pytest plugin for analyzing resource usage during test sessions
MIT License
173 stars 16 forks source link

Ensure py35 support #34

Closed jraygauthier closed 3 years ago

jraygauthier commented 3 years ago

Description

Replace use of literal string interpolation by plain old "my string {}".format(var).

This minimal change allow the library to be used with a python 3.5 interpreter.

For some reason (maybe older pytest in my env), most tests were failing with assert pymon_path.exists().

However, all example under examples were generating the .pymon db and so was it generated in my project.

The content of .pymon seems alright.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

js-dieu commented 3 years ago

Hello

Thanks for your contribution! Your changes seems alright to me. I wasn't planning support for Python3.5 but if the only changes required for being compatible with this version are the one you made, let's move on.

By the way, which pytest version are you using?

jraygauthier commented 3 years ago

Hi,

thanks for merging and the nice pytest plugin.

About pytest, until we get an opportunity to upgrade our target system, we're stuck using py35 and pytest 3.10.1. That might change soon but in the meantime we have to make with this situation.

js-dieu commented 3 years ago

Hi,

Thanks for the insights. I noticed you forgot to add yourself to the contributor list. This is now fixed :)