altendky commented 2 years ago

Description

This is a naive resolution to https://github.com/CFMTech/pytest-monitor/issues/50. It may not really make sense but it does seem to avoid the exception by using getattr(request.node, "monitor_results", False) to both avoid the attribute error and to avoid running the rest of the code in this unexpected scenario.

This is primarily being shared as a reference point. If you see other things that should be done feel free let me know, replace this with another PR, or just push changes here.

Fixes #50

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] ~I have made corresponding changes to the documentation~
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes (not just the CI)
[ ] ~Any dependent changes have been merged and published in downstream modules~
[x] I have provided a link to the issue this PR adresses in the Description section above (If there is none yet, create one !)
[x] I have updated the changelog
[ ] ~I have labeled my PR using appropriate tags (in particular using status labels like Status: Code Review Needed, Business: Test Needed or Status: In Progress if you are still working on the PR)~