There was a bug that resulted in some tests not failing when the cmd flag --no-monitor is set. Raising a BaseException in the corresponding code that runs when monitoring is disabled (line 210) solves the issue.
Fixes #79
pytest-monitor.py:205 raise e instead of return e
[x] Bug fix (non-breaking change which fixes an issue)
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
~- [ ] I have commented my code, particularly in hard-to-understand areas~
~- [ ] I have made corresponding changes to the documentation~
[x] My changes generate no new warnings
~- [ ] I have added tests that prove my fix is effective or that my feature works~
~- [] New and existing unit tests pass locally with my changes (not just the CI)~
~- [ ] Any dependent changes have been merged and published in downstream modules~
[x] I have provided a link to the issue this PR adresses in the Description section above (If there is none yet,
create one !)
Description
There was a bug that resulted in some tests not failing when the cmd flag
--no-monitor
is set. Raising a BaseException in the corresponding code that runs when monitoring is disabled (line 210) solves the issue.Fixes #79
pytest-monitor.py:205
raise e
instead ofreturn e
Checklist:
Status: Code Review Needed
,Business: Test Needed
orStatus: In Progress
if you are still working on the PR)