search

CFSworks / wavebird-reversing

Reverse-engineering the WaveBird protocol for the betterment of mankind
214 stars 11 forks source link

Color uncertainty in explanation of graphs in chapter 5. #4

Closed scottnm closed 7 months ago

scottnm commented 7 months ago

In the "A closer look at the wave bird's line code" section of Ch5, there's a description which references reds/greens

image

These are probably our 0s and 1s. We can't really do much besides guess here, but let's arbitrarily call the green one '1' (because the plateau at the very end is high) and the red one '0'. If we're wrong we can come back and change it.

Are "green" and "red" supposed to refer to colors in either of those two graphics? the first one is blue and the second two are both green but nothing is red? I'm not really sure what "red" refers to. I may be totally misreading what this section is trying to convey (disclaimer: I'm a total beginner to all of this radio stuff and even ignoring the color stuff I'm sort of struggling to see the pattern between the blue and green graphs which probably isn't helping)

can you help clarify for me?

CFSworks commented 7 months ago

Haha, oh man! Looks like my deuteranopia got the better of me. Red and green, though distinct to me, don't look that different, so probably I was intending to change one of the figures to be red later, then missed it when proof-reading.

The lower figure is supposed to be drawn with a red line, not a green one. I'll push a fix for this.

Thanks for reaching out (and for reading)!

scottnm commented 7 months ago

Of course! Thanks for putting together this awesome resource. It's been really helpful and approachable!